Fix android build StopTextInput error #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought that it is used in many locations, but apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix android build StopTextInput error"
Purpose of change
(Should) fix #2158
Describe the solution
Use SDL_StopTextInput() instead of StopTextInput().
SDL_StopTextInput() being a wrapper that we didn't port yet from DDA.
Testing
I can't test it (I can't build the Android version locally).
But, since it uses a known function instead and that was already what was used in precedent versions of DDA.
Worse case scenario, the diary is buggy on Android.
Best case scenario, everything works perfectly.
In both cases, the Android build won't be broken anymore, so people will be able to download the experimental again.